Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v8: out of bounds copy #55261

Merged
merged 1 commit into from
Oct 7, 2024
Merged

v8: out of bounds copy #55261

merged 1 commit into from
Oct 7, 2024

Conversation

ronag
Copy link
Member

@ronag ronag commented Oct 4, 2024

Fixes: #54573

@ronag ronag self-assigned this Oct 4, 2024
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Oct 4, 2024
@ronag
Copy link
Member Author

ronag commented Oct 4, 2024

@nodejs/buffer

@RedYetiDev RedYetiDev added buffer Issues and PRs related to the buffer subsystem. v8 module Issues and PRs related to the "v8" subsystem. labels Oct 4, 2024
ramidzkh
ramidzkh reviewed Oct 4, 2024
View reviewed changes
lib/v8.js Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Oct 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.89%. Comparing base (d2ad9b4) to head (dd44a41).
Report is 288 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #55261      +/-   ##
==========================================
- Coverage   88.41%   87.89%   -0.53%     
==========================================
  Files         652      652              
  Lines      186594   186611      +17     
  Branches    36054    35757     -297     
==========================================
- Hits       164980   164014     -966     
- Misses      14883    15821     +938     
- Partials     6731     6776      +45
Files with missing lines Coverage Δ
lib/v8.js 98.64% <100.00%> (-0.69%) ⬇️

... and 92 files with indirect coverage changes

ramidzkh
ramidzkh reviewed Oct 4, 2024
View reviewed changes
lib/v8.js Outdated Show resolved Hide resolved
RedYetiDev
RedYetiDev reviewed Oct 4, 2024
View reviewed changes
Copy link
Member

@RedYetiDev RedYetiDev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can mark the original author as a co-author, if needed?

nit: "v8" might be a better subsystem than "buffer"

test/parallel/test-v8-deserialize-buffer.js Outdated Show resolved Hide resolved
@ronag ronag force-pushed the 54573 branch 2 times, most recently from c716656 to 7332ad1 Compare October 4, 2024 11:13
@ronag ronag changed the title fix: out of bounds copy v8: out of bounds copy Oct 4, 2024
ramidzkh
ramidzkh reviewed Oct 4, 2024
View reviewed changes
test/parallel/test-v8-deserialize-buffer.js Outdated Show resolved Hide resolved
lib/v8.js Outdated Show resolved Hide resolved
@arneg arneg mentioned this pull request Oct 4, 2024
Closed
@ronag ronag force-pushed the 54573 branch 2 times, most recently from 0d57b24 to 5c04ef2 Compare October 5, 2024 12:17
@ronag ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 5, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 5, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62927/

@ronag @ramidzkh
v8: out of bounds copy
dd44a41 
Fixes: nodejs#54573

Co-authored-by: ronag <ronagy@icloud.com>
Co-authored-by: ramidzkh <ramidzkh@gmail.com>
@ronag ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 5, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 5, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62929/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62935/

@RedYetiDev RedYetiDev added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 7, 2024
joyeecheung
joyeecheung approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@joyeecheung joyeecheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though I think this could do better with the commit description (why the regression happened).

@ronag ronag added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 7, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 7, 2024
@nodejs-github-bot nodejs-github-bot merged commit deb5eff into nodejs:main Oct 7, 2024
63 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in deb5eff

aduh95 pushed a commit that referenced this pull request Oct 9, 2024
@ronag @ramidzkh @aduh95
v8: out of bounds copy
ea7aaf3 
Fixes: #54573

Co-authored-by: ronag <ronagy@icloud.com>
Co-authored-by: ramidzkh <ramidzkh@gmail.com>
PR-URL: #55261
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@aduh95 aduh95 mentioned this pull request Oct 9, 2024
Merged
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
@ronag @ramidzkh @louwers
v8: out of bounds copy
de156d9 
Fixes: nodejs#54573

Co-authored-by: ronag <ronagy@icloud.com>
Co-authored-by: ramidzkh <ramidzkh@gmail.com>
PR-URL: nodejs#55261
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@marco-ippolito marco-ippolito added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Nov 16, 2024
tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
@ronag @ramidzkh @tpoisseau
v8: out of bounds copy
2a5390e 
Fixes: nodejs#54573

Co-authored-by: ronag <ronagy@icloud.com>
Co-authored-by: ramidzkh <ramidzkh@gmail.com>
PR-URL: nodejs#55261
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RedYetiDev RedYetiDev RedYetiDev left review comments

@ramidzkh ramidzkh ramidzkh left review comments

@joyeecheung joyeecheung joyeecheung approved these changes

@anonrig anonrig anonrig approved these changes

@mcollina mcollina Awaiting requested review from mcollina

@ShogunPanda ShogunPanda Awaiting requested review from ShogunPanda

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. buffer Issues and PRs related to the buffer subsystem. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. needs-ci PRs that need a full CI run. v8 module Issues and PRs related to the "v8" subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parcel 2.12.0 malloc(): corrupted top size in Node 22.7.0
7 participants
@ronag @nodejs-github-bot @anonrig @joyeecheung @ramidzkh @RedYetiDev @marco-ippolito